[Entity Analytics] Move risk scoring painless to static files... again (with sorting fix after test failure) #183844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…based weighting the category based weighting, like all weighting, isn't used and we probably won't re-implement it in the next version of risk scoring this commit probably doesn't work. i can't get integration tests running locally I put the painless scripts in a directory and I load them from the file system at runtime. We should figure out how to bundle the scripts possibly. I'm not sure that it matters a lot, but I would like any static analysis processes to be able to work with this code as usual. e.g. i'd like to get a static-time error if a file is missing vs needing to run the risk engine task to find out a file is missing
…stic/kibana into risk-score-painless-refactor
…stic/kibana into risk-score-painless-refactor
hop-dev
added
release_note:skip
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
hop-dev
changed the title
hop-dev
changed the title
jaredburgettelastic
approved these changes
May 20, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @hop-dev |
kibanamachine
added
v8.15.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This code was originally approved and merged in #182038
It was then reverted in #183759 after a test failure.
The previous code had introduced flakiness, occasionally the inputs would be supplied to risk scoring in the wrong order causing the score to decrease. Re-adding the sorting in the reduce script has fixed this.
Here is the only new code: a8cbb1c
Flaky test run 🟢