Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Obs AI Ops > Anomaly Detection][KEYBOARD]: Anomalies table rows have a number of tooltips that cannot receive keyboard focus #183807

Merged
merged 2 commits into from
May 22, 2024

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 20, 2024

Closes: https://github.com/elastic/observability-dev/issues/3398

Description

The Obs Anomaly Detection Single Metric Viewer has an Anomalies table with at least three tooltips that cannot be reached by keyboard focus. Screenshot attached below.

Steps to recreate

  1. Open the Obs Anomaly Detection view
  2. Create a new anomaly detection job
  3. From the Anomaly Detection Jobs table, click the Single Metric Viewer icon
  4. Tab through the page, to the Anomalies table underneath the chart
  5. Expand a row in the table using the arrow icon at the beginning of a row
  6. Keep tabbing, and verify the tooltips in the expanded row never receive focus or become visible

What was changed:

  1. EuiToolTip was replaced to EuiIconTip

… have a number of tooltips that cannot receive keyboard focus

Closes: elastic/observability-dev#3398
@alexwizp
Copy link
Contributor Author

/ci

@alexwizp alexwizp added Team:Observability Team label for Observability Team (for things that are handled across all of observability) v8.15.0 release_note:skip Skip the PR/issue when compiling release notes Project:Accessibility labels May 20, 2024
@alexwizp alexwizp marked this pull request as ready for review May 20, 2024 09:02
@alexwizp alexwizp requested a review from a team as a code owner May 20, 2024 09:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

@alexwizp alexwizp added the backport:skip This commit does not require backporting label May 21, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.2MB 4.2MB -198.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@walterra walterra self-requested a review May 22, 2024 09:57
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, also did a local test.

@alexwizp alexwizp merged commit f023c2c into elastic:main May 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Observability Team label for Observability Team (for things that are handled across all of observability) v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants