Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add asset inventory AWS CloudFront fetcher #2209

Closed
wants to merge 5 commits into from

Conversation

kubasobon
Copy link
Member

  • ensure AWS SDK cloudfront
  • add AWS CloudFront provider
  • add AWS CloudFront mocks
  • add AWS CloudFront test cases

Summary of your changes

Screenshot/Data

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

Copy link

mergify bot commented May 16, 2024

This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

Copy link

github-actions bot commented May 16, 2024

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 197
⬜ Skipped 33

Copy link

mergify bot commented May 17, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b inventory-aws-cloufront upstream/inventory-aws-cloufront
git merge upstream/main
git push upstream inventory-aws-cloufront

@kubasobon
Copy link
Member Author

Discussed with @tinnytintin10. We are no longer interested in CloudFront assets.

@kubasobon kubasobon closed this May 27, 2024
@kubasobon kubasobon deleted the inventory-aws-cloufront branch May 27, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant