Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize drogon test build speed #1580

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Optimize drogon test build speed #1580

wants to merge 2 commits into from

Conversation

marty1885
Copy link
Member

  • Convert macros into functions to reduce compiler load

@an-tao @ken-matsui
Update lib/inc/drogon/drogon_test.h
901c679 
Co-authored-by: Ken Matsui <26405363+ken-matsui@users.noreply.github.com>
@marty1885
Copy link
Member Author

FYI, there's some problem with this PR that I'm looking into. I optimize the build speed by hiding most testing related code into function. However this introduces incompatibility as coroutines sometimes cannot be called directly in a function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ken-matsui ken-matsui ken-matsui left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marty1885 @ken-matsui @an-tao