-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(render-engine): move cache to viewport #2188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c31b854
to
28af776
Compare
View Deployment
|
10db720
to
aef9846
Compare
196b018
to
4762414
Compare
a4138c4
to
cf26fa1
Compare
f14a428
to
37e4950
Compare
c827f73
to
5d4d3b7
Compare
DR-Univer
reviewed
May 22, 2024
packages/engine-render/src/components/sheets/extensions/background.ts
Outdated
Show resolved
Hide resolved
packages/engine-render/src/components/sheets/extensions/font.ts
Outdated
Show resolved
Hide resolved
f24d3a3
to
0b81b50
Compare
…did not refresh whole viewport
chore: eslint fix
fix: new viewport need more param222 test: mock canvas fix: rm useless
fix: expand shouldupdatecache chore: better code
0b81b50
to
613e3dd
Compare
fix: update visible cache viewport area
613e3dd
to
d988566
Compare
DR-Univer
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A description of the proposed changes:
Moving the cache canvas from the spreadsheet to the viewport is primarily for the scenario of freezing rows and columns.
How to test them:
Performance: The FPS performance during scrolling should theoretically be consistent with the performance when there are no frozen rows or columns.
Font rendering: specially in scenarios involving overflow and merged cells spanning frozen rows and columns.
Correct texture mapping: such as avoiding blank textures and ensuring complete rendering of text and background colors.
BREAKING CHANGE:
Before:
cache canvas was controlled by spreadsheet.
After:
cache canvas was created by viewport