-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix flyout behaviour switching exception #22453
base: main
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
What to do with these failing tests? |
@imuller can you add UITests to this? Here's an example |
@PureWeen Can you check the added tests |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
public override string Issue => "FlyoutPage Android app crashing on orientation change when flyout is open"; | ||
|
||
[Test] | ||
[Category(UITestCategories.FlyoutPage)]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the last ]
from this line?
D:\a\_work\1\s\src\Controls\tests\TestCases.Shared.Tests\Tests\Issues\Issue20858.cs(16,41): error CS1519: Invalid token ']' in class, record, struct, or interface member declaration [D:\a\_work\1\s\src\Controls\tests\TestCases.iOS.Tests\Controls.TestCases.iOS.Tests.csproj]
393 Warning(s)
8 Error(s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz Done ✅
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@jsuarezruiz Any idea why these tests are failing? |
@jsuarezruiz @PureWeen When will this PR get approval? |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@jsuarezruiz Can you re-run the tests. Should be fixed now. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@jsuarezruiz @jfversluis It looks like other tests are failing, that does not has to do anything with this PR. What to do in this case? |
Description of Change
Two issues where fixed in this PR:
Issues Fixed
#20858
#18161