-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Just trigger SizeChanged when Window size changes #22413
Conversation
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
8e57d91
to
fd5ea38
Compare
Co-authored-by: Shane Neuville <shane94@hotmail.com>
Co-authored-by: Shane Neuville <shane94@hotmail.com>
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@@ -199,7 +200,7 @@ public double MinimumHeight | |||
} | |||
|
|||
int _batchFrameUpdate = 0; | |||
|
|||
bool disableHandlerUpdate; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chatted with @mattleibow about this one a bit, and I think my suggestions are somewhat just digging us into a deeper hole here :-)
I think we've been trying to fix this issue the wrong way for some time now and need to revert this entire method back to what it originally looked like here
And then change this method
private protected override void UpdateHandlerValue(string property)
{
if (disableHandlerUpdate)
return;
base.UpdateHandlerValue(property);
}
to
private protected override void UpdateHandlerValue(string property)
{
if (_batchFrameUpdate > 0)
return;
base.UpdateHandlerValue(property);
}
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Looks like the error are unrelated with my changes, from logs I could see something about Cake |
I wonder if this PR fixes #21306 as well. My PR #21357 touches I don't have my macOS machine with me now to test it but to verify if the bug is fixed or not, one can:
|
@MartyIX it did not it seems. I added a comment to the issue with a tiny bit more detail, but yeah, we need to fix this sooner rather than later. |
Yes, I added some debug info in #21306 (comment). So I think it's clear what happens. Not so much clear how to fix it (at least to me). |
Description of Change
Issues Fixed
Fixes #17991
Fixes #21306