-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] InputTransparent="true" on a Layout breaks child controls - Fix #22345
base: main
Are you sure you want to change the base?
Conversation
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@@ -417,6 +417,8 @@ public static void MapContainerView(IViewHandler handler, IView view) | |||
handler.HasContainer = viewHandler.NeedsContainer; | |||
else | |||
handler.HasContainer = view.NeedsContainer(); | |||
|
|||
handler.UpdateValue(nameof(IView.Visibility)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to add
handler.UpdateValue(nameof(IView.Opacity))
and remove this line from LabelHandler.windows.cs
public static void MapOpacity(ILabelHandler handler, ILabel label)
{
handler.UpdateValue(nameof(IViewHandler.ContainerView)); // this line
handler.PlatformView.UpdateOpacity(label);
handler.ToPlatform().UpdateOpacity(label);
}
I think when "handler.UpdateValue(nameof(IViewHandler.ContainerView));" was originally added we didn't have the correct MapContainerview flow, so it made sense there
You only need to update the ContainerView if that property would result in the container getting added/removed
We got a few issues with the changing container view that I tried to look at here #13114 I don't think my PR is right and needs to be done differently, but this container view issue is all over the properties. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
handler.UpdateValue(nameof(IView.Visibility)); | ||
|
||
#if WINDOWS | ||
handler.UpdateValue(nameof(IView.Opacity)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know if it is just windows only? Somehow I feel opacity is such a basic feature it affects more and we just saw it with windows first.
If we don't want to move the cheese to much in the PR, maybe just make this comment an issue and I can have a look when I get back to my keyboard.
Issues Fixed
Fixes #22289
bug.mov
fixed.mov