Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGAPP-1079: Ltr content rtl layouts #762

Merged
merged 4 commits into from
Sep 21, 2022

Conversation

f1sh1918
Copy link
Contributor

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

  1. Go to Testumgebung -> switch lang to AR -> check local news
  2. go to events and check list items (details are remote content)

Note:

  • Couldn't find anything to do for offers (mentioned in the ticket)
  • We can think about using the new text component everywhere (separate refactoring ticket)

…d base text component that is content aware, replaced Text component for ListItem and NewsListItem
Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on android, Works fine for events and news.

native/src/components/Caption.tsx Show resolved Hide resolved
native/src/components/base/Text.tsx Show resolved Hide resolved
native/src/constants/contentDirection.ts Outdated Show resolved Hide resolved
native/src/constants/contentDirection.ts Outdated Show resolved Hide resolved
native/src/constants/contentDirection.ts Show resolved Hide resolved
native/src/constants/contentDirection.ts Show resolved Hide resolved
@steffenkleinle
Copy link
Member

steffenkleinle commented Sep 19, 2022

* Couldn't find anything to do for offers (mentioned in the ticket)

I don't understand that and can't find anything in the ticket.

* We can think about using the new text component everywhere (separate refactoring ticket)

👍

Copy link
Member

@ztefanie ztefanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested.

native/src/constants/contentDirection.ts Outdated Show resolved Hide resolved
@f1sh1918 f1sh1918 merged commit 5c673ff into main Sep 21, 2022
@f1sh1918 f1sh1918 deleted the IGAPP-1079-ltr-content-rtl-layouts branch September 21, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants