New rule set to detekt marketplace.js #7299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7299 +/- ##
=========================================
Coverage 84.31% 84.31%
Complexity 4149 4149
=========================================
Files 573 573
Lines 11888 11888
Branches 2458 2458
=========================================
Hits 10023 10023
Misses 613 613
Partials 1252 1252 ☔ View full report in Codecov by Sentry. |
Kiolk
force-pushed
the
rules/new_set_rules_to_marketplace
branch
from
8dd6613
to
a2beeec
Compare
schalkms
reviewed
May 17, 2024
website/src/data/marketplace.js
Outdated
| @@ -229,6 +229,17 @@ export const extensions = [ | |||
| ], | |||
| usesTypeResolution: true, | |||
| }, | |||
| { | |||
| title: "Kiolk's Detekt Rules", | |||
| description: "This set contains rule that helps to improve readability and to keep single convention in the whole project.", | |||
There was a problem hiding this comment.
Suggested change
| description: "This set contains rule that helps to improve readability and to keep single convention in the whole project.", | |
| description: "This set contains rules that help to improve readability and to keep a single project-wide convention.", |
There was a problem hiding this comment.
Also this description is a bit too generic. Can we describe what your rule is doing instead here?
There was a problem hiding this comment.
Updated and added addition description.
cortinico
reviewed
May 18, 2024
website/src/data/marketplace.js
Outdated
| @@ -229,6 +229,17 @@ export const extensions = [ | |||
| ], | |||
| usesTypeResolution: true, | |||
| }, | |||
| { | |||
| title: "Kiolk's Detekt Rules", | |||
There was a problem hiding this comment.
Can we call this UseInvokeForOperator instead?
Kiolk
force-pushed
the
rules/new_set_rules_to_marketplace
branch
from
a2beeec
to
309b1f2
Compare
Kiolk
force-pushed
the
rules/new_set_rules_to_marketplace
branch
from
2fe1223
to
22bf1d0
Compare
schalkms
reviewed
May 28, 2024
Kiolk
force-pushed
the
rules/new_set_rules_to_marketplace
branch
from
22bf1d0
to
755bedd
Compare
BraisGabin
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contain information about new rule set that I want to add to marketplace page. General information about set you can find in GitHub repository. In current moment it contains only one rule, I will add more in the future.