-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change interface reinit values #17032
Change interface reinit values #17032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. This looks very reasonable (and is also more efficient).
doc/news/changes/minor/20240516Heinz
Outdated
@@ -0,0 +1,3 @@ | |||
Fixed: Only pass the sizes of quadratures instead of vectors of Quadrature objects to FERemoteEvaluationCommunicator::reinit_faces(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this. FERemoteEvaluationCommunicator
is a new feature.
5e926a5
to
644330d
Compare
/rebuild |
|
644330d
to
c1f6d13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failure is spurious and after all serial tests passed, let me merge.
@bangerth @kronbichler
As discussed in #17017
I will mark this as WIP until I checked that everything works.