Look-up table for Hermite #16265
Open
Look-up table for Hermite #16265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, showing which basis functions correspond to which derivatives on each edge.
Rombur
reviewed
Nov 14, 2023
| */ | ||
| Table<2, unsigned int> | ||
| get_dofs_corresponding_to_outward_normal_derivatives( | ||
| const unsigned int derivative_order) const; |
There was a problem hiding this comment.
What is derivative_order exactly?
| const std::vector<unsigned int> l2h = | ||
| get_lexicographic_to_hierarchic_numbering(); | ||
| const unsigned int dofs_per_cell = Utilities::pow(degree + 1, dim); | ||
| AssertDimension(dofs_per_cell, l2h.size()); |
There was a problem hiding this comment.
Suggested change
| AssertDimension(dofs_per_cell, l2h.size()); | |
| AssertDimension(Utilities::pow(degree + 1, dim), l2h.size()); |
or you can use [[maybe_unused]]
There was a problem hiding this comment.
since dim is known at compile time can't we use Utilities::fixed_power : https://www.dealii.org/current/doxygen/deal.II/namespaceUtilities.html#a834c6b595ada6f8e73c78d9bbd8ec551
| * batch index: Index of the current batch in the list of batches | ||
| * local_index: Index of the current DoF within a batch | ||
| * | ||
| * The variable correction is used because the pattern of relevant |
There was a problem hiding this comment.
If correction is an offset, just call the variable offset
…showing its usage in calculating a cutFEM stabilisation matrix.
peterrum
reviewed
Dec 22, 2023
|
|
||
| Table<2, unsigned int> | ||
| get_dofs_corresponding_to_outward_normal_derivatives( | ||
| const unsigned int derivative_order) const; |
There was a problem hiding this comment.
Suggested change
| const unsigned int derivative_order) const; | |
| const unsigned int derivative_order) const; | |
Comment on lines
+600
to
+602
| Table<2, unsigned int> dofs_of_nonzero_values_on_faces = | ||
| dynamic_cast<const FE_Hermite<DIM> &>(dof_handler.get_fe()) | ||
| .get_dofs_corresponding_to_outward_normal_derivatives(0); |
|
|
||
|
|
||
| /** | ||
| * Test for the FE_Hermite method function |
There was a problem hiding this comment.
This function does not seem to do anything!?
|
|
||
| for (unsigned int j = 5; j < 6; j += 2) | ||
| { | ||
| CutHermiteWaveCircle::WaveSolver system(system_parameters, j); |
There was a problem hiding this comment.
The test seems to be quite large. How long does the test take? Do you really want to all of this or just a subset?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a function to FEHermite to output a look-up table of DOFs, showing which basis functions correspond to which derivatives on each edge. This function is useful for various purposes, such as boundary implementations and cutFEM stabilisation terms.