Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] scroll-multiplier option #1827

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

[WIP] scroll-multiplier option #1827

wants to merge 2 commits into from

Conversation

djvs
Copy link

@djvs djvs commented Mar 29, 2023

This PR adds a "scroll-multiplier" option to help with paginating tons of content. I'm guesstimating how some of this stuff works so could use a review. Docs also not added (not positive which ones to put it in).

@DaveDavenport
Copy link
Collaborator

DaveDavenport commented Mar 29, 2023

Can you explain what this PR does/adds?

@djvs
Copy link
Author

djvs commented Mar 29, 2023

If you use the scroll wheel to navigate through a long list of results, it'll go 8 lines with a scroll-multiplier of 8, instead of 1, for each tick of the scroll wheel.

@DaveDavenport
Copy link
Collaborator

Doesn't this patch also change the behaviour of the keybindings?

To me it feels weird to just skip pages. I am not sure this is desirable? I would more assume a 'kinetic?' scrolling, so it speeds up when your keep scrolling. If you skip 8 pages, it might be hard to get to the item on page 4 now?

@djvs
Copy link
Author

djvs commented Mar 29, 2023

Oh, yeah, it does, I can fix the binding issue. But yeah it only goes a fraction of a page at a time with a reasonably small scroll multiplier.

@DaveDavenport
Copy link
Collaborator

In keyb.c the scroll action is bound to a certain 'action'. (see rofi -show keys for the bindings).

You could f.e. bind this to page up/down if you want to jump bigger, or we should make a new action that does (kinetic) scrolling.

@djvs
Copy link
Author

djvs commented Mar 29, 2023

I pushed a fix for that - it's not "kinetic" as in with a decaying trajectory over time and all that jazz, but you could extend it like that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants