Subscriptions: bi-directional subscription streaming. #7747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds SubscribeTopicEvents proto API which dynamically subscribes to pubsub topics based on dapr/proposals#52. This is a basic gRPC implementation of the API whereby, like Subscription hot-reloading today, subscribing to a topic will reload _every_ active subscription for the current daprd. In a future PR, reloading of Subscriptions will be granular to the specific pubsub topic. Stream subscriptions are also only active once daprd declares the application as both present and ready. Dynamic stream subscriptions should be active both whether a app is running or not, as well as whether it is ready or not. This will be addressed in a future PR. Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7747 +/- ##
==========================================
- Coverage 61.39% 57.01% -4.38%
==========================================
Files 265 477 +212
Lines 22609 25809 +3200
==========================================
+ Hits 13880 14716 +836
- Misses 7579 9929 +2350
- Partials 1150 1164 +14 ☔ View full report in Codecov by Sentry. |
Signed-off-by: joshvanl <me@joshvanl.dev>
hot-op-inf-comp test Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7747 +/- ##
==========================================
- Coverage 61.39% 57.01% -4.38%
==========================================
Files 265 477 +212
Lines 22609 25809 +3200
==========================================
+ Hits 13880 14716 +836
- Misses 7579 9929 +2350
- Partials 1150 1164 +14 ☔ View full report in Codecov by Sentry. |
yaron2
requested changes
May 24, 2024
Signed-off-by: joshvanl <me@joshvanl.dev>
yaron2
reviewed
May 24, 2024
yaron2
approved these changes
May 28, 2024
elena-kolevska
pushed a commit
to elena-kolevska/dapr
that referenced
this pull request
Jun 10, 2024
* Subscriptions: bi-directional subscription & publish streaming. Adds SubscribeTopicEvents proto API which dynamically subscribes to pubsub topics based on dapr/proposals#52. This is a basic gRPC implementation of the API whereby, like Subscription hot-reloading today, subscribing to a topic will reload _every_ active subscription for the current daprd. In a future PR, reloading of Subscriptions will be granular to the specific pubsub topic. Stream subscriptions are also only active once daprd declares the application as both present and ready. Dynamic stream subscriptions should be active both whether a app is running or not, as well as whether it is ready or not. This will be addressed in a future PR. Signed-off-by: joshvanl <me@joshvanl.dev> * Updates go.mod go version to 1.22.3 in e2e apps Signed-off-by: joshvanl <me@joshvanl.dev> * Remove small context timeout on httpserver int tests Signed-off-by: joshvanl <me@joshvanl.dev> * Wait for daprd2 to be ready before calling meta endpoint in hot-op-inf-comp test Signed-off-by: joshvanl <me@joshvanl.dev> * Increase int test daprd wait until ready timeout to 30s Signed-off-by: joshvanl <me@joshvanl.dev> * Assert httpendpoint int test resp body with eventually Signed-off-by: joshvanl <me@joshvanl.dev> * Set subscription APIs Alpha1 Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: Elena Kolevska <elena@kolevska.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SubscribeTopicEvents proto API which dynamically subscribes to pubsub topics based on dapr/proposals#52.
This is a basic gRPC implementation of the API whereby, like Subscription hot-reloading today, subscribing to a topic will reload every active subscription for the current daprd. In a future PR, reloading of Subscriptions will be granular to the specific pubsub topic.
Stream subscriptions are also only active once daprd declares the application as both present and ready. Dynamic stream subscriptions should be active both whether a app is running or not, as well as whether it is ready or not. This will be addressed in a future PR.