-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(http/cookies): allow spaces to be present in the cookie value #14455
Open
anton7c3
wants to merge
2
commits into
crystal-lang:master
Choose a base branch
from
anton7c3:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+69
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Apr 8, 2024
anton7c3
force-pushed
the
master
branch
2 times, most recently
from
April 8, 2024 13:46
eeb056a
to
ebce743
Compare
Sija
approved these changes
Apr 8, 2024
Looks good to me and fixes the current issue I'm seeing (#14435) |
bararchy
approved these changes
Apr 8, 2024
hovsater
reviewed
Apr 8, 2024
anton7c3
force-pushed
the
master
branch
3 times, most recently
from
April 15, 2024 14:53
c748b0d
to
912f1c1
Compare
Sija
reviewed
Apr 15, 2024
anton7c3
force-pushed
the
master
branch
2 times, most recently
from
May 16, 2024 16:09
dac7efe
to
1c91eaa
Compare
Sija
approved these changes
May 16, 2024
straight-shoota
approved these changes
May 20, 2024
bararchy
approved these changes
May 29, 2024
beta-ziliani
approved these changes
May 29, 2024
ysbaddaden
reviewed
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just left a question about a convoluted case (spaces around the quotes), otherwise 👍
Fixes crystal-lang#14435. Move parse_set_cookie example to the correct location.
straight-shoota
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14435.
Move parse_set_cookie example to the correct location.