-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow copier-templates-extensions as an extra #1633
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But the poetry.lock
file needs to be updated:
poetry lock --no-update
|
(The stuff about limits is bogus, because older versions used to have Python caps, that's not the correct solution and would result in the wrong solve) |
I could probably just change the dummy version number, not sure if there's a better way to fix this with the poetry-dynamic-versioning hack. Edit: I did that, can try something else if someone has a different suggestion. |
I assume you installed the |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Ah, no, I was just using my brew-installed poetry, which doesn't support adding plugins. I just unlinked my poetry with brew, then installed poetry with pipx and injected the plugin. That fixed it. Other tools (like PDM or Hatch) usually respect your |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1633 +/- ##
==========================================
+ Coverage 97.20% 97.39% +0.19%
==========================================
Files 48 48
Lines 4728 4728
==========================================
+ Hits 4596 4605 +9
+ Misses 132 123 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Nice! The RTD build is failing because |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Okay, fixed readthedocs. On the nix jobs (CI / flake-check), it's still giving:
|
This allows pipx users to use this:
Or this:
Instead of this:
I think this was mentioned a while back, but never added.
I'm not very familiar with non-PEP 621 backends (Poetry. Just Poetry.), so hopefully I got the syntax correct. Also not sure if you want a min version here.