Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split out dev apt dependencies #32476

Merged
merged 6 commits into from
May 21, 2024
Merged

split out dev apt dependencies #32476

merged 6 commits into from
May 21, 2024

Conversation

macdoos
Copy link
Contributor

@macdoos macdoos commented May 19, 2024 •
edited

resolves #32470

Description

This PR updates the tools/install_ubuntu_dependencies.sh script to improve flexibility and user interaction.

Changelog:

  • Adds a prompt for installing extra packages
  • Adds a NON_INTERACTIVE variable for a non-interactive mode using an environment variable

Verification
To run interactively:

./tools/install_ubuntu_dependencies.sh

To run in non-interactive mode:

NON_INTERACTIVE=yes ./tools/install_ubuntu_dependencies.sh

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 19, 2024 •
edited

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@github-actions github-actions bot added the tools label May 19, 2024
@macdoos macdoos marked this pull request as draft May 19, 2024 04:05
@macdoos macdoos marked this pull request as ready for review May 19, 2024 04:14
@macdoos macdoos changed the title draft: split out dev apt dependencies split out dev apt dependencies May 19, 2024
@macdoos macdoos marked this pull request as draft May 19, 2024 04:23
@macdoos macdoos marked this pull request as ready for review May 19, 2024 04:58
@adeebshihadeh
Copy link
Contributor

Thanks! Want to pick up another bounty like #26956?

@adeebshihadeh adeebshihadeh merged commit e0fa26b into commaai:master May 21, 2024
18 of 21 checks passed
@adeebshihadeh adeebshihadeh mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[$100 bounty] tools: split out dev apt dependencies
2 participants
@macdoos @adeebshihadeh