Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subaru: Increase Global Gen 2 steering torque #32451

Conversation

CheckYourSix
Copy link

@CheckYourSix CheckYourSix commented May 17, 2024

Back in 2022, the max steering torque for Subaru Global Gen 2 vehicles had a value of to 2047. This was deemed to be too high and subsequently reduced to 1100, then 1000. These limits are far too low and make the vehicle incapable of handling basic highway curves.

After testing the factory EyeSight system on a 2020 Outback (f284f22298d498cc|2023-05-25--23-45-24--0) it's clear that the factory system sets the limit at 1400. A previous PR #29627 was made to increase the limit back to 1400 but was closed.

While 1400 is substantially better than 1000, it does not provide enough torque to handle all highway curves, requiring frequent manual intervention. I have been testing OpenPilot with a steering torque limit of 1600 for a few thousand miles of highway and city driving. This has worked great on nearly every road I've driven all up and down the East Coast. The increased torque has never caused me any safety concerns or made any maneuver that felt too aggressive to correct.

I propose increasing the limit to 1600 to provide a much better driving experience for all users affected by this and I'm happy to provide any logs or support necessary to facilitate merging this into master.

Relevant Routes

f284f22298d498cc|2023-05-25--23-45-24--0 | Route 1: Stock Eyesight

Requires

Addresses

Related (closed) PRs

Copy link
Contributor

github-actions bot commented May 17, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

Copy link
Contributor

github-actions bot commented Jun 1, 2024

This PR has had no activity for 14 days. It will be automatically closed in 3 days if there is no activity.

@github-actions github-actions bot added the stale label Jun 1, 2024
@adeebshihadeh
Copy link
Contributor

We're not able to immediately validate this, so I'm going to close.

When we have the time (and a more general lateral tuning strategy), we'll do this for all the cars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants