Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: Optimize setup-with-retry to run faster by lowering the size #32437

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

wip: Optimize setup-with-retry to run faster by lowering the size #32437

wants to merge 28 commits into from
+17 −5

Conversation

JustinMiehle
Copy link

This aims to improve the runtime of setup-with-retry by making the docker image smaller.
#30706

@JustinMiehle
leanify dockerfile
7eb1add 
Initial attempt to reduce size of docker base image
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@JustinMiehle
add chown=$USER to install scripts
bbdc9f9
@JustinMiehle
Fix premature copying of python script
e9f0516
@JustinMiehle
attempt to make apt-get a bit less hungry
a28f6ba
@JustinMiehle
Further attempts at apt-get
cc7e040
@JustinMiehle
Bogus change to be reverted
d1ca87d
@JustinMiehle
Add buildarg for testing
05422f4
@JustinMiehle
fix mistake in passing build_arg
afc0038
@JustinMiehle
see if caching is in effect on my branch
53f1805
@JustinMiehle
Try out gha cache
0196af9
@JustinMiehle
Fix typo in docker build command
da36834
@JustinMiehle
trigger empty to see if caching already works
fd348c7
@JustinMiehle
this did not work - another try
88ce56d
@JustinMiehle
try local caching
ba60993
@JustinMiehle
going strong with the typos
df8ca4f
@JustinMiehle
configuring buildx
cf01322
@JustinMiehle
fix missing colon
f7058d1
@JustinMiehle
more attempts
2a9d36b
@JustinMiehle
fix template
8456861
@JustinMiehle
forgot the line separator
caeb6cd
@JustinMiehle
remove misguided remove
59e8e9d
@JustinMiehle
it was the ampersand
8176095
@JustinMiehle
Test if it works
2a970c8
@JustinMiehle
mode=max is way too aggressive
29600d7
@JustinMiehle
another time
cd0cca7
@JustinMiehle
Let us see if this flies
2b6d768
@JustinMiehle
revert layering changes
5671808
@JustinMiehle
Fix merge conflict and try to pull
bb52bad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JustinMiehle