Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HKG: Hyundai Ioniq 5 N 2024 Car Port #32396

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

HKG: Hyundai Ioniq 5 N 2024 Car Port #32396

wants to merge 4 commits into from
+18 −2

Conversation

Kirito3481
Copy link
Contributor

@Kirito3481 Kirito3481 commented May 11, 2024 •
edited

Checklist

  • added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot:
  • route with stock system: 78ad5150de133637/2024-05-09--03-49-06
  • car harness used (if comma doesn't sell it, put N/A): Hyundai M

Issues

  • Harness Relay Malfunction occurs when OP Long is enabled.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 11, 2024 •
edited

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@Kirito3481 Kirito3481 changed the title Car port for Hyundai Ioniq 5 N 2024 HKG: Hyundai Ioniq 5 N 2024 Car Port May 11, 2024
@Kirito3481 Kirito3481 marked this pull request as draft May 11, 2024 11:56
@sshane
Copy link
Contributor

sshane commented May 13, 2024 •
edited

Can this car be kept inside the IONIQ_5 platform?

@Kirito3481
Copy link
Contributor Author

Can this car be kept inside the IONIQ_5 platform?

Is there a way to distinguish between regular ioniq5 and n in interface.py? Mass, wheelbase, and steerRatio are slightly different.
Or is it okay if it's slightly different?

@sshane
Copy link
Contributor

sshane commented May 14, 2024 •
edited

The wheelbase looks identical (our 2.97 should be 2.99), mass differs due to the battery size (but it already doesn't match exactly for the various trims we support), so that all looks fine.

If we can't detect that turn signal difference reliably, sounds like I didn't do any verification on it yet, then you can leave it as a separate platform. You should rebase before you perform any more changes.

sshane
sshane reviewed May 14, 2024
View reviewed changes
selfdrive/car/hyundai/values.py Outdated
Comment on lines 544 to 545
CANFD_RADAR_SCC_CAR = {CAR.GENESIS_GV70_1ST_GEN, CAR.KIA_SORENTO_4TH_GEN, CAR.GENESIS_GV80, CAR.KIA_CARNIVAL_4TH_GEN, CAR.KIA_SORENTO_HEV_4TH_GEN,
CAR.IONIQ_5_N}
Copy link
Contributor

@sshane sshane May 14, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is correct?

@sshane
Copy link
Contributor

sshane commented May 14, 2024

You can add HyundaiFlags.CANFD_NO_RADAR_DISABLE for now

@github-actions github-actions bot added the car vehicle-specific label May 14, 2024
sshane
sshane reviewed May 14, 2024
View reviewed changes
selfdrive/car/hyundai/carstate.py Outdated
@@ -208,7 +208,7 @@ def update_canfd(self, cp, cp_cam):

# TODO: alt signal usage may be described by cp.vl['BLINKERS']['USE_ALT_LAMP']
left_blinker_sig, right_blinker_sig = "LEFT_LAMP", "RIGHT_LAMP"
if self.CP.carFingerprint == CAR.HYUNDAI_KONA_EV_2ND_GEN:
if bool(cp.vl['BLINKERS']['USE_ALT_LAMP']):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this a tuple check for the two cars? don't add a flag yet, as once we detect it, it won't require a flag

@thisLambo
Copy link

Just to add to the fingerprints, here's the fingerprint for the US fwdCamera
b'\xf1\x00NE1NMFC AT USA LHD 1.00 1.04 99211-NI000 231219'

@Kirito3481
Copy link
Contributor Author

Just to add to the fingerprints, here's the fingerprint for the US fwdCamera b'\xf1\x00NE1NMFC AT USA LHD 1.00 1.04 99211-NI000 231219'

fwdRadar is same?

@thisLambo
Copy link

thisLambo commented May 23, 2024 •
edited

Just to add to the fingerprints, here's the fingerprint for the US fwdCamera b'\xf1\x00NE1NMFC AT USA LHD 1.00 1.04 99211-NI000 231219'

fwdRadar is same?

Yeah, b'\xf1\x00NE1N RDR ----- 1.00 1.00 99110-NI000 '

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshane sshane sshane left review comments

Assignees
No one assigned
Labels
car port car vehicle-specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kirito3481 @sshane @thisLambo @adeebshihadeh