Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabana: add signal table for real-time signal value visualization #32375

Closed
wants to merge 1 commit into from

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented May 8, 2024

The Signal Table widget displays current signal values to users in a clear and intuitive manner.

  1. In the message panel, the signal table shows the current values of all signals along with their recent reception times:
    Screenshot from 2024-05-09 02-32-22

  2. In the chart panel, the signal table shows current values and recent reception times for selected signals.
    Screenshot from 2024-05-09 02-33-26

video:

Kazam_screencast_00146.webm

This PR also simplifies video layouts, adding "LOADING", "PAUSED" text for clarity the replay's status:

2024-05-09_16-38

Copy link
Contributor

github-actions bot commented May 8, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@github-actions github-actions bot added the tools label May 8, 2024
@deanlee deanlee marked this pull request as draft May 8, 2024 18:50
@deanlee deanlee force-pushed the cabana_signal_view branch 9 times, most recently from 09532cf to c77e9e2 Compare May 9, 2024 09:49
Copy link
Contributor

This PR has had no activity for 14 days. It will be automatically closed in 3 days if there is no activity.

@github-actions github-actions bot added the stale label May 24, 2024
Copy link
Contributor

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant