Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/update_dmonitoring: Improve readability of r_xyz matrix initialization #32359

Merged
merged 1 commit into from
May 22, 2024

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented May 6, 2024

This PR introduces temporary variables to initialize the r_xyz matrix, enhancing readability and maintainability.

Copy link
Contributor

github-actions bot commented May 6, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@github-actions github-actions bot added the ui label May 6, 2024
@adeebshihadeh
Copy link
Contributor

@ZwX1616 can you review? I think this is worth merging.

@adeebshihadeh adeebshihadeh merged commit d234085 into commaai:master May 22, 2024
28 checks passed
@deanlee deanlee deleted the ui_improve_update_dmonitoring branch May 25, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants