-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/loader reconciliation 5 #32605
Draft
dylandreimerink
wants to merge
11
commits into
cilium:main
Choose a base branch
from
dylandreimerink:feature/loader-reconciliation-5
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/loader reconciliation 5 #32605
dylandreimerink
wants to merge
11
commits into
cilium:main
from
dylandreimerink:feature/loader-reconciliation-5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove datapath.Loader and only use loader/types.Loader - Add LoaderContext for passing device and address data to the loader. In the future this can contain other data queried from the agent. - Query for node addresses in the orchestrator instead of loader and pass them as part of LoaderContext. - Add rate limiting so we don't reinit twice due to propagation delay to Table[NodeAddress] Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Retry failed reinitialization after 10 second delay. Signed-off-by: Jussi Maki <jussi@isovalent.com>
If we pass the whole LocalNode we will reinitialize on irrelevant changes. Signed-off-by: Jussi Maki <jussi@isovalent.com>
- drop useless ipsecMu - pass LoaderContext in template cache update to recompute hash based on it - also collect the fallback node addresses Signed-off-by: Jussi Maki <jussi@isovalent.com>
This mechanism proved out to make the use of the Table[NodeAddress] inconvenient. Reimplement the fallback as a computation around a set of node addresses instead. It also was not useful to have the fallback addresses from non-selected devices. Signed-off-by: Jussi Maki <jussi@isovalent.com>
The Chdir() done by Daemon.init was racing with the loader causing just compiled object files to not be found. Change the Chdir() in initEnv() to switch to StateDir directly and remove the Chdir() from Daemon.init. Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
dylandreimerink
added
the
dont-merge/preview-only
Only for preview or testing, don't merge it.
label
May 17, 2024
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
May 17, 2024
github-actions
bot
added
the
sig/policy
Impacts whether traffic is allowed or denied based on user-defined policies.
label
May 17, 2024
Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/loader-reconciliation-5
branch
from
May 22, 2024 09:40
369e294
to
c4a0d26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
dont-merge/preview-only
Only for preview or testing, don't merge it.
sig/policy
Impacts whether traffic is allowed or denied based on user-defined policies.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP