Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create musescore.rb #8498

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

Franceschinie
Copy link
Contributor

@Franceschinie Franceschinie commented Jul 22, 2023

Fixes #

Works properly:

  • x86_64
  • i686
  • armv7l
  • `aarch64'
CREW_TESTING_REPO=https://github.com/Franceschinie/chromebrew.git CREW_TESTING_BRANCH=pach-2 CREW_TESTING=1 crew update

packages/musescore.rb Outdated Show resolved Hide resolved
packages/musescore.rb Outdated Show resolved Hide resolved
end

def self.postinstall
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add def self.remove block to uninstall?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this was changed to an appimage install, the remove block is not necessary unless there are some settings saved in the user home directory.

Copy link
Collaborator

@uberhacker uberhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

packages/musescore.rb Outdated Show resolved Hide resolved
homepage 'musescore.org'
version '4.1.0'
license 'GPL-3'
compatibility 'aarch64, x86_64'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only x86_64 compatible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does this need to be changed to compatibility 'x86_64'?

FileUtils.mv 'squashfs-root/share' ,"#{CREW_DEST_PREFIX}"
FileUtils.mv 'squashfs-root/include' ,"#{CREW_DEST_PREFIX}"
FileUtils.mv 'squashfs-root/lib' ,"#{CREW_DEST_PREFIX}"
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you notice a new file located in your local repo at manifest/x86_64/m/musecore.filelist? That will need to be commited in the PR too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm creating a bash script https://github.com/Franceschinie/musescore

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change permissions to executable and definitely don't want to run with sudo. Installs should add all files inside of CREW_PREFIX (/usr/local by default) which should be writable for the chronos user. If this is not the case then the install.sh script needs to be modified to adjust for this relative location.

version '4.1.0'
license 'GPL-3'
compatibility 'x86_64'
source_url 'https://raw.githubusercontent.com/Franceschinie/musescore/main/install.sh'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag a release for version control?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants