new package bsdgames #6311
Open
new package bsdgames #6311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uberhacker
reviewed
Oct 18, 2021
| system "echo bsd_games_cfg_dm_nogamesfile='#{CREW_PREFIX}/etc/dm/nogames' | tee -a config.params" | ||
| system "echo bsd_games_cfg_hangman_wordsfile='#{CREW_PREFIX}/share/dict/words' | tee -a config.params" | ||
| system "echo bsd_games_cfg_wtf_acronymfile='#{CREW_PREFIX}/share/misc/acryonyms' | tee -a config.params" | ||
| system "echo bsd_games_cfg_ncurses_lib='$(pkg-config --libs-only-l ncurses)' | tee -a config.params" # Fix ncurses support |
There was a problem hiding this comment.
Write to a variable instead?
config_params = <<~EOF
bsd_games_cfg_build_dirs="#{@bsdgames}"
bsd_games_cfg_docdir="#{CREW_PREFIX}/share/doc/bsdgames"
EOF
IO.write('config.params', config_params)
Then you don't need all the escapes and redundant system "echo ... | tee -a config.params" lines.
There was a problem hiding this comment.
I honestly don't know why I didn't think of that 🧠
uberhacker
reviewed
Oct 18, 2021
uberhacker
reviewed
Oct 18, 2021
| def self.prebuild | ||
| puts 'Configuring'.lightblue | ||
| system "sed -i 's:-g -O2::g' configure" | ||
| system "sed -i 's:/usr/games:#{CREW_PREFIX}/bin:' wargames/wargames" |
There was a problem hiding this comment.
Move the sed lines to def self.patch?
|
As soon as I started messing around with the package file, I started getting the weirdest errors, some of them preprocessor errors, others collect2 (linker) errors, etc. I worked so hard to get it to work that, if this is okay with you, I'd like to leave it like this. |
|
Keep working at it. You will solve it eventually. |
uberhacker
added
the
hacktoberfest 🎃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, I know I have a long history of trying to split up this package and get it added with all the games separately. It just wasn't worth the effort. Here's the whole package on one package file. Works on x86_64.