changes of resources should change build.ninja fingerprint #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chen3feng
reviewed
Jul 8, 2021
src/blade/scala_targets.py
Outdated
| @@ -56,7 +56,9 @@ def __init__(self, | |||
| visibility=visibility, | |||
| tags=tags, | |||
| kwargs=kwargs) | |||
| # we need expand resources in regular format to change ninja fingerprint. | |||
| self._process_resources(resources) | ||
| self.attr['expended_resources'] = self._process_regular_resources(self.attr['resources']) |
There was a problem hiding this comment.
我觉得这里解析不了 location 引用啊，需要测一下。或者碰巧展开后后续也能解析？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.