spelling: added detailed message to spelling test script #14884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please fix CI failure |
SteLeo1602
force-pushed
the
testSpellingUpdate
branch
from
dbd37f0
to
628e54e
Compare
romani
reviewed
May 27, 2024
.ci/test-spelling-unknown-words.sh
Outdated
| @@ -55,7 +55,8 @@ echo "Run w" | |||
|
|
|||
| printDetails() { | |||
| echo '' | |||
| echo 'If you are ok with the output of this run, you will need to' | |||
| echo 'If you are ok with the output of this run, you will need \ | |||
| to run the following entire multiline command:' | |||
There was a problem hiding this comment.
I would do this in two separate echo commands, no reason on line wrap here.
There was a problem hiding this comment.
echo 'If you are ok with the output of this run,'
Other text by separate echo command.
SteLeo1602
force-pushed
the
testSpellingUpdate
branch
from
628e54e
to
9a426db
Compare
romani
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional details to the message to clarify for the beginners what they need to do exactly and ensure they won't confuse the command with the rest of the report.