doc/cephfs: edit "Pinning Subvolumes..." #57574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit the section "Pinning Subvolumes and Subvolume Groups" in doc/cephfs/fs-volumes.rst. This is merely a grammar edit. Signed-off-by: Zac Dover <zac.dover@proton.me>
anthonyeleven
approved these changes
May 20, 2024
| @@ -811,31 +811,32 @@ to policies. This can distribute load across MDS ranks in predictable and | |||
| stable ways. Review :ref:`cephfs-pinning` and :ref:`cephfs-ephemeral-pinning` | |||
| for details on how pinning works. | |||
|
|
|||
| Pinning is configured by: | |||
| Run a command of the following form to configure pinning for subvolumegroups: | |||
There was a problem hiding this comment.
I think we write "subvolume groups" elsewhere.
zdover23
added a commit
to zdover23/ceph
that referenced
this pull request
May 27, 2024
Use the term "subvolume groups" instead of "subvolumegroups" where the term appears in plain English. The string "subvolumegroups" is correct in commands, and remains unchanged. Also add formatting to command output, to make clearer that the output is indeed output. Fixes: ceph#57574 (comment) Signed-off-by: Zac Dover <zac.dover@proton.me>
14 tasks
zdover23
added a commit
to zdover23/ceph
that referenced
this pull request
May 28, 2024
Use the term "subvolume groups" instead of "subvolumegroups" where the term appears in plain English. The string "subvolumegroups" is correct in commands, and remains unchanged. Also add formatting to command output, to make clearer that the output is indeed output. Fixes: ceph#57574 (comment) Signed-off-by: Zac Dover <zac.dover@proton.me> (cherry picked from commit b303417)
zdover23
added a commit
to zdover23/ceph
that referenced
this pull request
May 28, 2024
Use the term "subvolume groups" instead of "subvolumegroups" where the term appears in plain English. The string "subvolumegroups" is correct in commands, and remains unchanged. Also add formatting to command output, to make clearer that the output is indeed output. Fixes: ceph#57574 (comment) Signed-off-by: Zac Dover <zac.dover@proton.me> (cherry picked from commit b303417)
zdover23
added a commit
to zdover23/ceph
that referenced
this pull request
May 28, 2024
Use the term "subvolume groups" instead of "subvolumegroups" where the term appears in plain English. The string "subvolumegroups" is correct in commands, and remains unchanged. Also add formatting to command output, to make clearer that the output is indeed output. Fixes: ceph#57574 (comment) Signed-off-by: Zac Dover <zac.dover@proton.me> (cherry picked from commit b303417)
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit the section "Pinning Subvolumes and Subvolume Groups" in doc/cephfs/fs-volumes.rst. This is merely a grammar edit.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e