Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crimson/osd/ops_executer: LIST_SNAPS only on CEPH_SNAPDIR #57561

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

guojidan
Copy link
Contributor

@guojidan guojidan commented May 20, 2024

fixes: https://tracker.ceph.com/issues/65663

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

Copy link
Contributor

@Matan-B Matan-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crimson/osd/ops_executer: LIST_SNAPS only on CEPH_SNAPDIR

@guojidan
Copy link
Contributor Author

jenkins test make check

@guojidan
Copy link
Contributor Author

jenkins test make check arm64

@guojidan
Copy link
Contributor Author

jenkins test windows

@Matan-B
Copy link
Contributor

Matan-B commented May 21, 2024

crimson/osd/ops_executer: LIST_SNAPS only on CEPH_SNAPDIR

@guojidan, Can you please rename the commit to: crimson/osd/ops_executer: LIST_SNAPS only on CEPH_SNAPDIR?

@guojidan
Copy link
Contributor Author

crimson/osd/ops_executer: LIST_SNAPS only on CEPH_SNAPDIR

@guojidan, Can you please rename the commit to: crimson/osd/ops_executer: LIST_SNAPS only on CEPH_SNAPDIR?

OK, thanks

@guojidan guojidan changed the title src/test/librados/snapshots_cxx.cc: enable LibRadosSnapshotsSelfManag… crimson/osd/ops_executer: LIST_SNAPS only on CEPH_SNAPDIR May 21, 2024
@guojidan
Copy link
Contributor Author

jenkins test windows

@Matan-B
Copy link
Contributor

Matan-B commented Jun 9, 2024

@Matan-B
Copy link
Contributor

Matan-B commented Jun 9, 2024

jenkins test windows

@Matan-B Matan-B merged commit 0c96a93 into ceph:main Jun 9, 2024
10 of 11 checks passed
@guojidan
Copy link
Contributor Author

guojidan commented Jun 9, 2024

thanks

@guojidan guojidan deleted the rollback branch June 9, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants