refact: Only use the arm64 runner to run the tests. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lincoln Wallace <lincoln.wallace@canonical.com>
locnnil
force-pushed
the
arm-runner-for-tests-only
branch
3 times, most recently
from
9795868
to
b620e85
Compare
Signed-off-by: Lincoln Wallace <lincoln.wallace@canonical.com>
locnnil
force-pushed
the
arm-runner-for-tests-only
branch
from
b620e85
to
3d8b24a
Compare
farshidtz
reviewed
May 3, 2024
| LOCAL_SERVICE_SNAP: ../${{ steps.snapcraft.outputs.snap }} | ||
| run: go test -failfast -p 1 -timeout 20m -v | ||
| LOCAL_SERVICE_SNAP: ../matter-pi-gpio-commander_2.0.0_arm64.snap | ||
| run: ls -la && go test -failfast -p 1 -timeout 20m -v |
There was a problem hiding this comment.
The snap version should not be hardcoded here.
Please remove debugging code (ls -la).
Signed-off-by: Lincoln Wallace <lincoln.wallace@canonical.com>
Signed-off-by: Lincoln Wallace <lincoln.wallace@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #53