Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of unsafe and panics #21

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

dgsantana
Copy link

This could be interesting to merge into master. It removes all panics from code, use results where possible, and also removes unsafe code, by using the rust implementation of deflate. There is also an attempt to create some fuzz testing, but probably needs more work.

@bvibber
Copy link
Owner

bvibber commented Nov 17, 2021

That's cool, I'll take a look over it when I have a chance!

How's the performance with the pure-Rust deflate? Regressing that is my main worry; I would strongly prefer to keep using zlib if it provides significantly better compression speed, and would not accept patches that degrade performance.

@dgsantana
Copy link
Author

I haven't done much performance testing, but didn't seen any big changes in speed, when using miniz. But I will make some tests to access performance. I also made miniz a feature, so it's possible to pick if one wants zlib or miniz. I just want to have an option of using a pure rust implementation. I also removed all the panics to avoid having the lib panic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants