Remove dpi scaling of minimum_width & maximum_width #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was left over from #1877. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
github-actions
bot
added
sources
✅ Deploy Preview for conkyweb canceled.
|
Caellian
changed the title
Caellian
commented
May 18, 2024
| @@ -661,8 +661,8 @@ bool display_output_wayland::main_loop_wait(double t) { | |||
| text_size.y() + 2 * border_total != height || scale_changed)) { | |||
| /* clamp text_width to configured maximum */ | |||
| if (maximum_width.get(*state)) { | |||
| int mw = global_window->scale * maximum_width.get(*state); | |||
There was a problem hiding this comment.
Didn't remove maximum_width scaling here.
| text_size = conky::vec2i(dpi_scale(minimum_width.get(*state)), 0); | ||
| text_size = conky::vec2i(minimum_width.get(*state), 0); |
There was a problem hiding this comment.
minimum_width shouldn't scale either.
|
Next step would be reverting these changes 😆, introducing proper unit support, and making raw numbers default to |
brndnmtthws
approved these changes
May 20, 2024
Caellian
added a commit
that referenced
this pull request
May 30, 2024
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Caellian
added a commit
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was left over from #1877.