Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/wildfly] Fix ingress annotations #25958

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Conversation

accettur
Copy link
Contributor

Fix ingress annotations

Ingress was including annotations from "persistence", not from "ingress"

Description of the change

Change ingress template to use annotations from Values.ingress.annotations

Benefits

annotations are used from correct location

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added wildfly triage Triage is needed labels May 16, 2024
@github-actions github-actions bot requested a review from carrodher May 16, 2024 19:29
@accettur accettur changed the title [bitnami/wildfly] Update ingress.yaml [bitnami/wildfly] Fix ingress annotations May 16, 2024
@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

Signed-off-by: Mauricio Accetturi Carvalho <accettur@unicamp.br>
@accettur
Copy link
Contributor Author

Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

Hi @carrodher,

I changed my pull request as instructed, could you review it?

Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 24, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 24, 2024
@github-actions github-actions bot removed the request for review from carrodher May 24, 2024 14:23
@github-actions github-actions bot requested a review from alemorcuq May 24, 2024 14:23
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Copy link

github-actions bot commented Jun 9, 2024

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Jun 9, 2024
alemorcuq and others added 2 commits June 10, 2024 12:37
Signed-off-by: Alejandro Moreno <amorenoc@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@alemorcuq alemorcuq merged commit 87a5fcc into bitnami:main Jun 10, 2024
7 checks passed
longnbao pushed a commit to longnbao/bitnami-helm-charts that referenced this pull request Jun 12, 2024
* [bitnami~wildfly] fix ingress annotations

Signed-off-by: Mauricio Accetturi Carvalho <accettur@unicamp.br>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

---------

Signed-off-by: Mauricio Accetturi Carvalho <accettur@unicamp.br>
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Alejandro Moreno <amorenoc@vmware.com>
Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>
Co-authored-by: Alejandro Moreno <amorenoc@vmware.com>
Signed-off-by: Long Bao <long.nguyen.bao@trustingsocial.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved stale 15 days without activity verify Execute verification workflow for these changes wildfly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/wildfly] Bad value in list for ingress.yaml annotations
4 participants