kernel: De-globalize validation caches #30141
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Instead clamp it to uint32::max if it exceeds it. Co-authored-by: Anthony Towns <aj@erisian.com.au>
TheCharlatan
force-pushed
the
noGlobalScriptCache
branch
from
79c9c55
to
4a1df97
Compare
|
Updated 79c9c55 -> 4a1df97 (noGlobalScriptCache_0 -> noGlobalScriptCache_1, compare) |
Move its ownership to the ChainstateManager class. Next to simplifying usage of the kernel library by no longer requiring manual setup of the cache prior to using validation code, it also slims down the amount of memory allocated by BasicTestingSetup.
Move it to the ChainstateManager class.
This is done in preparation for the following commit.
Move its ownership to the ChainstateManager class. Next to simplifying usage of the kernel library by no longer requiring manual setup of the cache prior to using validation code, it also slims down the amount of memory allocated by BasicTestingSetup. Use this opportunity to make CSignatureCache RAII styled
TheCharlatan
force-pushed
the
noGlobalScriptCache
branch
from
4a1df97
to
5b1576b
Compare
|
Updated 4a1df97 -> 5b1576b (noGlobalScriptCache_1 -> noGlobalScriptCache_2, compare) |
The validation caches are currently setup independently from where the rest of the validation code is initialized. This makes their ownership semantics unclear. There is also no clear enforcement on when and in what order they need to be initialized. The caches are always initialized in the
BasicTestingSetupalthough a number of tests don't actually need them.Solve this by moving the caches from global scope into the
ChainstateManagerclass. This simplifies the usage of the kernel library by no longer requiring manual setup of the caches prior to using theChainstateManager. Tests that need to access the caches can instantiate them independently.This pull request is part of the libbitcoinkernel project.