Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static to isBuiltin() check in ide-helper:models #1541

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bram-pkg
Copy link

Summary

For some reason, the static keyword as a return type, does not return isBuiltin() === true, so a \\ is added. We need to manually add it to the built in check.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

For some reason, the `static` keyword as a return type, does not return `isBuiltin()` === true, so a `\\` is added. We need to manually add it to the built in check.
@mfn
Copy link
Collaborator

mfn commented Apr 25, 2024

Can you please add a test?

@bram-pkg
Copy link
Author

Ofcourse :)

@bram-pkg
Copy link
Author

Tests added @mfn

@mfn mfn self-assigned this May 4, 2024
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, verified the change with the test, that helps a lot!

I've also added the changelog entry.

@barryvdh LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants