Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text: Handle cases that "-" appears more than once #282

Open
wants to merge 7 commits into
base: url-from-stdin
Choose a base branch
from

Conversation

Jason23347
Copy link
Contributor

text: Handle cases that "-" appears more than once
search: Remove line-break char end of URL string

Jason23347 and others added 4 commits April 5, 2020 22:07
Signed-off-by: jason23347 <jason23347@gmail.com>
[ismael@iodev.co.uk: Fixed typo and removed unneeded freeing code in main]
Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
Signed-off-by: jason23347 <jason23347@gmail.com>
[ismael@iodev.co.uk: Fixed typo and removed unneeded freeing code in main]
Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
@ismaell ismaell self-requested a review April 6, 2020 14:53
@ismaell
Copy link
Member

ismaell commented Apr 6, 2020

Please re-base, as I've made some changes that conflict with yours (e.g. I've already fixed the \n removal, and it's combined with determining the string length).

@Jason23347
Copy link
Contributor Author

OK, I will do the re-base later.

@Jason23347
Copy link
Contributor Author

Oops, there is a bug if arguments are like "- http://ur.com", I will try to fix it tomorrow.

Signed-off-by: jason23347 <jason23347@gmail.com>
Signed-off-by: jason23347 <jason23347@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants