Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: maximum_concurrency option in on_sqs_message #2104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adityamohta
Copy link
Contributor

Issue #2031

Description of changes:

This PR adds option to configure MaximumConcurrency value for sqs event source lambdas.

The option can be used like following:

@app.on_sqs_message(queue='my-queue', batch_size=1, maximum_concurrency=20)
def handle_sqs_message(event):
    ...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leobarcellos
Copy link

This is really useful.

@adityamohta
Copy link
Contributor Author

The test failure for python3.8 in ci seem unrelated to this PR.

@jamesls
Copy link
Member

jamesls commented May 30, 2024

Thanks for the pull request.

Yeah those py38 errors should be fixed in #2092, so rebasing from master should fix this. I can take a look at this tomorrow.

@adityamohta adityamohta force-pushed the aditya/add-maximum-concurrency-option-for-sqs-event-source-lambda branch from 67e604b to 075bd77 Compare May 30, 2024 01:40
@adityamohta
Copy link
Contributor Author

Yeah those py38 errors should be fixed in #2092, so rebasing from master should fix this. I can take a look at this tomorrow.

Ah, makes sense, thanks for sharing that @jamesls ! 🙇🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants