Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(stepfunction-tasks): eventbridge aws. event source prefix check is more strict than it should be #30237

Merged
merged 3 commits into from
Jun 6, 2024
Merged

chore(stepfunction-tasks): eventbridge aws. event source prefix check is more strict than it should be #30237

merged 3 commits into from
Jun 6, 2024

Conversation

pahud
Copy link
Contributor

@pahud pahud commented May 16, 2024 •
edited

  1. fix the event source validation
  2. move the validation from renderEntries() to validateEntries()
  3. add unit tests

Issue # (if applicable)

Closes #30191

Reason for this change

Description of changes

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 16, 2024 14:49
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels May 16, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 16, 2024
@pahud pahud marked this pull request as ready for review May 16, 2024 14:50
aws-cdk-automation
aws-cdk-automation previously requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

aws-cdk-automation
aws-cdk-automation previously requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@pahud pahud changed the title fix(stepfunction-tasks): EventBridge aws. event source prefix check is more strict than it should be fix(stepfunction-tasks): eventbridge aws. event source prefix check is more strict than it should be May 16, 2024
@github-actions github-actions bot mentioned this pull request May 20, 2024
Closed
@pahud pahud added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 23, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 23, 2024
@github-actions github-actions bot mentioned this pull request Jun 1, 2024
Closed
@pahud
Copy link
Contributor Author

pahud commented Jun 6, 2024

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jun 6, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 6, 2024
@pahud pahud changed the title fix(stepfunction-tasks): eventbridge aws. event source prefix check is more strict than it should be chore(stepfunction-tasks): eventbridge aws. event source prefix check is more strict than it should be Jun 6, 2024
@aws-cdk-automation aws-cdk-automation dismissed stale reviews from themself June 6, 2024 20:58

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@paulhcsun
Copy link
Contributor

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 6, 2024

update

✅ Branch has been successfully updated

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 6, 2024
@paulhcsun paulhcsun self-requested a review June 6, 2024 23:22
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d3ffbb3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8f4d4d7 into aws:main Jun 6, 2024
14 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Leo10Gama pushed a commit to Leo10Gama/aws-cdk that referenced this pull request Jun 11, 2024
@pahud
chore(stepfunction-tasks): eventbridge aws. event source prefix check…
862bf36 
… is more strict than it should be (aws#30237)

1. fix the event source validation
2. move the validation from renderEntries() to validateEntries() 
3. add unit tests

### Issue # (if applicable)

Closes aws#30191

### Reason for this change



### Description of changes



### Description of how you validated changes



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

@paulhcsun paulhcsun Awaiting requested review from paulhcsun

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-stepfunctions-tasks: EventBridge aws. event source prefix check is more strict than it should be
3 participants
@pahud @paulhcsun @aws-cdk-automation