This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Section 101 doc improvements #466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor editing for clarity: - Grammar fix on line 8 - Reminder to select the 'IAM roles' acknowledgement checkbox while deploying the template. - Clarify that in order to test kubectl autocompletion you open a new terminal window. The language about restarting a session was not clear.
buzzsurfr
suggested changes
Jun 7, 2018
| @@ -77,7 +77,7 @@ image:cloud9-run-script.png[Running the script in Cloud9 Terminal] | |||
| [NOTE] | |||
| All shell commands _(starting with "$")_ throughout the rest of the workshop should be run in this tab. You may want to resize it upwards to make it larger. | |||
|
|
|||
| At this point you can restart the Cloud9 IDE terminal session to ensure that the kublectl completion is enabled. Once a new terminal window is opened, type `kubectl get nodes`. You do not have to run the command. It is normal for this command to fail with an error message if you run it. You have not yet created the Kubernetes cluster. We are merely testing to make sure the `kubectl` tool is installed on the command line correctly and can autocomplete. | |||
| At this point you can open a new Cloud9 IDE terminal session to ensure that the kublectl completion is enabled. Once a new terminal window is opened, type `kubectl get n` and hit `Tab`. The completion should offer a choice of items including `node`. You do not have to run the command. It is normal for this command to fail with an error message if you run it. You have not yet created the Kubernetes cluster. We are merely testing to make sure the `kubectl` tool is installed on the command line correctly and can autocomplete. | |||
There was a problem hiding this comment.
This is trying to test both kubectl and bash completion. I would rather separate these two, ideally making testing bash completion optional.
rddefauw
commented
Jun 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor editing for clarity:
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.