chore: track code coverage in PRs #5312
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
general review: I like the idea of putting this action |
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/tests.yaml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/tests.yaml
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/tests.yaml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/tests.yaml
.github/workflows/tests.yaml
Outdated
| run: go get -v -t -d ./... | ||
| - name: Run tests | ||
| run: go test main_test.go main.go | ||
| if: steps.verify-changed-files.outputs.files_changed == 'true' |
There was a problem hiding this comment.
We need to run tests still, only skip the coverage step please.
There was a problem hiding this comment.
it looks like it's not working either way :(
There was a problem hiding this comment.
@kilianc can you enable github actions and github pages for your fork for cover branch and try and run it.
There was a problem hiding this comment.
done: kilianc#1 (comment)
but the action to detect changes is borked, I am going to use git directly or find a new one if that's ok
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/tests.yaml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/tests.yaml
It would be nice to track code coverage for this repo
Summary by CodeRabbit