New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add styling for table header and striping in docbook converter #4421
base: main
Are you sure you want to change the base?
Conversation
tabstyle does seem to be a standard attribute in DocBook, so we're now heading in the right direction. Are these values standardized anywhere? |
There doesn't seem to be any standardization of these values according to our research. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with adding tabstyle
for table stripes. However, I'd like to stick with the same names that are used by the HTML converter. Those are as follows:
- stripes-all
- stripes-even
- stripes-odd
I don't like the idea of a headerbg option. It's not part of AsciiDoc (i.e., not compliant) and I don't see why this can't be controlled using a role (e.g., .header-bg
).
I can see the benefit of mapping the stripes attribute to tabstyle (or a role) since that way you don't need to define it twice.
Also, please add a test.
I have now fixed the tabstyle names, removed the headerbg and added a test. However, I'm not that fluent in ruby, so I hope the test works. I had trouble running all the tests on my machine due to ruby gem issues... but I was able to run this single test and it seemed to work. |
There needs to be an associated issue in order for this to be merged. Unless it's a documentation changes, pull requests are not accepted without an issue since there is then no reference for why the change was made. |
Added bug #4593 |
Adds a tab style attribute with striping and header background value if they are present. The actual table striping is now handled downstream in docbook xsl. Replaces pulls #4412 and #4413 , Fixes #4593
An example of the table.row.properties needed to use these features
EDIT 2024-01-08: Updated the example to work with the latest changes