Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #2521 don't hyphenate autolink when hyphenation is enabled #2513

Merged
merged 1 commit into from
May 27, 2024

Conversation

meonkeys
Copy link
Contributor

@meonkeys meonkeys commented Apr 2, 2024

(see commit log message for details, including caveats)

(sorry about the force push, I won't do any more of those)

@mojavelinux
Copy link
Member

I've updated the implementation to use a skipping filter instead of a backreference. I think this is a cleaner and more stable approach.

@mojavelinux
Copy link
Member

mojavelinux commented May 26, 2024

Once the tests pass, I will accept this change. A few notes about future PRs that will help them get merged faster.

First, every non-docs PR should have an associated issue. Without an issue, PRs mostly get ignored because they lack context and are difficult to track using our process. Before submitting a PR, always start by creating an issue. The issue is where you can discuss implementation details so they don't get lost in the PR. These comments do not belong in the commit message. You can mention in the issue that you intend to submit a PR, which will help get the issue scheduled.

Both the CHANGELOG entry and the PR should reference the issue.

Aside from that, I'd actually say the PR was pretty good. Don't worry about force pushing in a PR. That is completely acceptable. The main goal is that you want to end up with only one commit.

@mojavelinux mojavelinux merged commit b46a8d2 into asciidoctor:main May 27, 2024
15 checks passed
@meonkeys meonkeys deleted the do-not-hyphenate-bare-URLs branch May 27, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants