-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: detect the dataIndex
type in table
#2317
Open
chenzn1
wants to merge
3
commits into
arco-design:main
Choose a base branch
from
chenzn1:types/table-types
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare preview |
chenzn1
force-pushed
the
types/table-types
branch
from
October 27, 2023 06:03
f607c74
to
78f2878
Compare
ts 编译直接报错了,麻烦再看下呢 |
chenzn1
force-pushed
the
types/table-types
branch
from
October 27, 2023 14:40
b45ad17
to
dabcc8a
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a20764c:
|
Fixed. |
chenzn1
changed the title
feat: add type to
types: add type to Oct 30, 2023
dataIndex
in tabledataIndex
in table
chenzn1
changed the title
types: add type to
types: detect the Oct 30, 2023
dataIndex
in tabledataIndex
type in table
@yinkaihui 可以合并吗,还是说有什么问题? |
yinkaihui
reviewed
Nov 6, 2023
抱歉。。 review 的忘记提交了 |
chenzn1
force-pushed
the
types/table-types
branch
2 times, most recently
from
November 6, 2023 08:30
a0367a9
to
9103d3b
Compare
代码冲突了,需要解决下 |
chenzn1
force-pushed
the
types/table-types
branch
from
December 27, 2023 06:55
9103d3b
to
43be890
Compare
chenzn1
force-pushed
the
types/table-types
branch
from
December 27, 2023 07:04
43be890
to
a20764c
Compare
解决了。 @yinkaihui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Background and context
Solution
How is the change tested?
Changelog
Column.dataIndex
增加类型提示Checklist:
npm run test
)feature
branch and others should be submitted tomain
branch)Other information