Enable Central Package Management #1386
Conversation
Directory.Packages.props
Outdated
| <PackageVersion Include="xunit.runner.visualstudio" Version="2.5.7"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
| </PackageVersion> |
There was a problem hiding this comment.
I believe PrivateAssets, IncludeAssets etc belongs to PackageReference and not PackageVersion. I pushed a fix for this.
There was a problem hiding this comment.
You are correct, thanks for noticing.
| <IncludeSymbols>true</IncludeSymbols> | ||
| <SymbolPackageFormat>snupkg</SymbolPackageFormat> | ||
| </PropertyGroup> | ||
|
|
There was a problem hiding this comment.
Aha, it seems .NET8 includes these by default now. Nice.
Starting with .NET 8, Source Link for the following source control providers is included in the .NET SDK and enabled by default
https://github.com/dotnet/sourcelink
However, we target netstandard2.0 in this project, so I guess we need to keep those?
Including the packagereference Microsoft.SourceLink.GitHub below.
There was a problem hiding this comment.
The way I understand this is that these settings and packagereference are only used at build/package time, not at runtime, so as long as UnitsNet is build with the .NET 8 SDK it should work with netstandard2.0.
I want to validate this but have some trouble. Even if I build the latest master unmodified with the dotnet build and dotnet pack commands from Build/build-functions.psm1 the resulting .nupkg has missing symbols and compiler flags when checked with https://nuget.info
There was a problem hiding this comment.
@angularsen any thoughts on this? Am I doing something wrong? Does this only work in CI?
There was a problem hiding this comment.
@Muximize CI should not do anything different I can think of.
As far as I can tell, the symbols package .snupkg includes the .pdb file as expected and .nupkg includes source code and has valid SourceLink for the commit I had currently checked out: 91a85e2dac60b420fabc44ebde71fc85dab33d6c
git checkout origin/master # Where origin is the original repository
cd UnitsNet
dotnet packUnitsNet -> X:\unitsnet\Artifacts\UnitsNet\net7.0\UnitsNet.dll
Successfully created package 'X:\unitsnet\Artifacts/UnitsNet\UnitsNet.5.50.0.nupkg'.
Successfully created package 'X:\unitsnet\Artifacts/UnitsNet\UnitsNet.5.50.0.snupkg'.
Testing the .nupkg file on nuget.info
Testing the .snupkg symbols file on nuget.info
| <!-- Optional: Build symbol package (.snupkg) to distribute the PDB containing Source Link --> | ||
| <IncludeSymbols>true</IncludeSymbols> | ||
| <SymbolPackageFormat>snupkg</SymbolPackageFormat> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
Same here, I think we need to keep this
This PR removes some seemingly unused dependencies, and moves all dependency versions to a single file according to Central Package Management.