Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pack items table update on edit #797

Open
wants to merge 3 commits into
base: andrew_testing
Choose a base branch
from

Conversation

Isthisanmol
Copy link
Collaborator

@Isthisanmol Isthisanmol commented Mar 31, 2024

Fixes edited item update in pack items table on native

Copy link

render bot commented Mar 31, 2024

Copy link

cloudflare-pages bot commented Mar 31, 2024

Deploying packrat with  Cloudflare Pages  Cloudflare Pages

Latest commit: 43e8b27
Status: ✅  Deploy successful!
Preview URL: https://104efbaa.packrat.pages.dev
Branch Preview URL: https://fix-pack-table-update-on-edi.packrat.pages.dev

View logs

Copy link

render bot commented Mar 31, 2024

Your Render PR Server at https://packrat-dev-pr-797.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-co4qfv8l5elc73afkni0.

@taronaleksanian
Copy link
Collaborator

@Isthisanmol can you please check if you see the same issue you have fixed by this PR here. Your solution is a good option, but it seems we update the tanstack-query cache once item created/updated (see useEditPackItem hook)

@Isthisanmol
Copy link
Collaborator Author

@Isthisanmol can you please check if you see the same issue you have fixed by this PR here. Your solution is a good option, but it seems we update the tanstack-query cache once item created/updated (see useEditPackItem hook)

Thanks for the feedback.I saw this issue only on native side and not on web.

Copy link

render bot commented Apr 4, 2024

Your Render PR Server at https://packrat-dev-pr-797.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-co4qfv8l5elc73afkni0.

Copy link

github-actions bot commented Apr 23, 2024

❌ Tests failed for this pull request. 😞

Test Logs


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Category Functionality and Total Weight Calculation Issue when Adding Items to Pack
2 participants