Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort and search functionality , -revert copy #796

Open
wants to merge 26 commits into
base: andrew_testing
Choose a base branch
from

Conversation

shahzaib-manzoor
Copy link
Collaborator

No description provided.

Copy link

render bot commented Mar 31, 2024

@shahzaib-manzoor shahzaib-manzoor changed the title revert copy sort, and search functionality sort, and search functionality , -revert copy Mar 31, 2024
@shahzaib-manzoor shahzaib-manzoor changed the title sort, and search functionality , -revert copy sort and search functionality , -revert copy Mar 31, 2024
Copy link

cloudflare-pages bot commented Mar 31, 2024

Deploying packrat with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0bc3c2e
Status: ✅  Deploy successful!
Preview URL: https://42f7f2f7.packrat.pages.dev
Branch Preview URL: https://search-issue-768.packrat.pages.dev

View logs

Copy link

render bot commented Mar 31, 2024

Your Render PR Server at https://packrat-dev-pr-796.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-co4p9jmd3nmc73aolb00.

@EngrAJ8888
Copy link
Collaborator

Hey @shahzi113awan
Confirmed that the sort and search functionality in both global and packs is now fixed. However, it seems there are errors with the search in the Trips. Please refer to the video below for details. Thanks!

6.mp4

@andrew-bierman
Copy link
Owner

Need to resolve conflicts and this is good to merge

Copy link
Owner

@andrew-bierman andrew-bierman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's resolve conflicts on this and get it merged when possible

@shahzaib-manzoor
Copy link
Collaborator Author

Conflicts resolved ~

Copy link
Owner

@andrew-bierman andrew-bierman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@EngrAJ8888
Copy link
Collaborator

Hi @shahzaib-manzoor, Thanks for implementing the updates. I've tested the new PR link, and while the sorting is now working correctly, it seems like the search functionality for trips/feed/pack isn't working as intended. Could you please take a look at this when you get a chance? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pack Search and Sorting Malfunction, Copy-Paste Feature Missing
6 participants