Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack Search and Sorting Malfunction, Copy-Paste Feature Missing #768

Closed
EngrAJ8888 opened this issue Mar 19, 2024 · 10 comments · May be fixed by #796
Closed

Pack Search and Sorting Malfunction, Copy-Paste Feature Missing #768

EngrAJ8888 opened this issue Mar 19, 2024 · 10 comments · May be fixed by #796
Assignees
Labels
bug Something isn't working

Comments

@EngrAJ8888
Copy link
Collaborator

EngrAJ8888 commented Mar 19, 2024

Describe the bug
The search and sorting features for packs aren't functioning correctly at the moment. Also, you can't paste copied items into other packs.

To Reproduce
Steps to reproduce the behavior:

  1. Visit the URL: https://packrat.world
    same issue here: https://packrat-dev-qj5h.onrender.com
  2. Log in to your account with the following credentials:
  3. Email: zoot3@email.com
  4. Password: 12345678
  5. Navigate to the main page and select “Pack”.
  6. Utilize the search engine to locate a saved pack.
  7. Attempt to use the sort option
  8. Open “Testing AJ” pack.
  9. Select Copy
  10. Navigate back to menu option and select any saved packs

Expected behavior

  • Search and sort options should operate seamlessly.
  • Users should be able to copy items from one pack and paste them into another.

Screenshots

5

Desktop (please complete the following information):

  • Windows 11
  • Microsoft Edge
  • Version: 122.0.2365.92

Smartphone (please complete the following information):

  • Device: iPhone15
  • OS: iOs17.4
  • Browser: safari
  • Version: 17.4
@shahzaib-manzoor shahzaib-manzoor self-assigned this Mar 24, 2024
@Tadjaur
Copy link
Collaborator

Tadjaur commented Mar 27, 2024

Users should be able to copy items from one pack and paste them into another.

@EngrAJ8888 The copy option only seems to add the pack link to the clipboard, so you can share or paste it wherever you want.

Does your comment means the current behavior is not expected and we need to instead copy all items of the current pack and paste them into another?

@shahzaib-manzoor
Copy link
Collaborator

@Tadjaur i'm currently working on this issue

@shahzaib-manzoor
Copy link
Collaborator

Sorting and search functionality is fixed

@shahzaib-manzoor
Copy link
Collaborator

Users should be able to copy items from one pack and paste them into another.

@EngrAJ8888 The copy option only seems to add the pack link to the clipboard, so you can share or paste it wherever you want.

Does your comment means the current behavior is not expected and we need to instead copy all items of the current pack and paste them into another?

@EngrAJ8888 ?
please clear this

@shahzaib-manzoor
Copy link
Collaborator

shahzaib-manzoor commented Mar 31, 2024

@EngrAJ8888 , @andrew-bierman

  • There is not any paste button while adding
    details of pack
  • There is not any save button in detail form if we have pasted items ,
  • Should the items append in previous ones or just override the existing ones

@andrew-bierman
Copy link
Owner

@EngrAJ8888 , @andrew-bierman

  • There is not any paste button while adding
    details of pack
  • There is not any save button in detail form if we have pasted items ,
  • Should the items append in previous ones or just override the existing ones

I believe there is some confusion around the button for copying the link to the pack for basic sharing, and the feature that copies a pack.

When actually copying a pack, you would create a new pack with the same items.

Currently there is no pasting functionality, we can add global items into an existing pack. Or copy and entire pack and modify our cloned version.

does that make sense?

@EngrAJ8888
Copy link
Collaborator Author

EngrAJ8888 commented Apr 8, 2024

Hi @shahzi113awan, I've checked using the preview link of the PR: #796
I've noticed that only four items can be added from the global item list. Could you please include this in the update? Please refer to the photo below for clarification.
image

@EngrAJ8888
Copy link
Collaborator Author

@shahzi113awan, bumping this one up. Thank you!

@EngrAJ8888
Copy link
Collaborator Author

EngrAJ8888 commented Apr 15, 2024

Hi @shahzi113awan, could you please provide an update? Below are the pending items that still need to be addressed:

  • Implement the option to copy the entire pack of other users and allowing them to modify the cloned pack.
  • When searching for global items to add to the pack, only the four most recently added items are currently showing.

I'm using this link for testing: https://packrat.pages.dev

Thanks!

@EngrAJ8888
Copy link
Collaborator Author

The pending items on this ticket are being addressed in another ticket. We'll proceed to close this one out. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants