Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A custom DISPLAY to determinate the socket_path. #196

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rysson
Copy link

@rysson rysson commented May 31, 2022

Add display argument to sync and async Connetion() classes
to determineate the socket_path. Useful when you work with many
Xephyr servers.

@rysson
Copy link
Author

rysson commented Jun 21, 2022

The socket reconnection support added.

@gibbz00
Copy link
Contributor

gibbz00 commented Sep 9, 2022

Will conflict with #199 Did the current version create errors or is this a "nice to have" thing?

@rysson
Copy link
Author

rysson commented Sep 9, 2022

Hi,
It's a "nice to have" thing.

It's easier to connect to many i3 servers with this PR. Similar to DISPLAY=:1, witch works for single connection.

If you accept #199, I could refactor this PR to avoid using xlib.
I can use something similar to:

if self._display:
    env = {**os.eviron, 'DISPLAY': self._display}
else:
    env = None
process = run([binary, '--get-socketpath'], stdout=PIPE, stderr=PIPE, env=env)

That's all what I need.

@gibbz00
Copy link
Contributor

gibbz00 commented Sep 9, 2022

Great clarification, thanks :)

I'm unfortunately not the package maintainer for this project, wish I was though. Just emailed the maintainer asking what's up and if I could help out. I'm thinking about creating a fork of this project since it feels unmaintained, but I'll see if he replies first. We'll just have to wait. So it's up to you if you want to preemptively do the refactor before that :)

@acrisci
Copy link
Member

acrisci commented Sep 11, 2022

👋 looking at this now

@acrisci
Copy link
Member

acrisci commented Sep 11, 2022

@rysson thanks, I accepted #199, can you fix the conflicts?

Add `display` argument to sync and async `Connetion()` classes
to determineate the socket_path. Useful when you work with many
Xephyr servers.
Search the socket path on reconnect if no user's socket_path defined.
@rysson
Copy link
Author

rysson commented Sep 12, 2022

@rysson thanks, I accepted #199, can you fix the conflicts?

Sure, I updated my commits. Now should be OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants