[ui] Remove intrinsic if not used by any viewpoint #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
reviewed
May 7, 2024
fabiencastan
reviewed
May 7, 2024
| @@ -292,6 +292,24 @@ Panel { | |||
|
|
|||
| function sendRemoveRequest() { | |||
| if (!readOnly) { | |||
| // look if the viewpoint's intrinsic is used by another viewpoint | |||
There was a problem hiding this comment.
Should be done after the removeImageRequest, isn't it?
There was a problem hiding this comment.
Maybe better to do it on the python side.
Instead of a generic call to reconstruction.removeAttribute(attribute), here:
https://github.com/alicevision/Meshroom/blob/7b691a05dd73c1aa1ee913aa11af84ba81d227b5/meshroom/ui/qml/WorkspaceView.qml#L81C17-L81C80
Add a removeImage and do all the checks in it (including the job done in allViewpointsCleared / removeAllImages).
https://github.com/alicevision/Meshroom/blob/7b691a05dd73c1aa1ee913aa11af84ba81d227b5/meshroom/ui/graph.py#L820C9-L820C24
There was a problem hiding this comment.
I created a removeImage to do checks of intrinsics, is it better ?
Just-Kiel
force-pushed
the
dev/updateIntrinsicsWhileRemovingImages
branch
from
0e06232
to
c50d3cc
Compare
fabiencastan
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deleting image from the ImageGallery, if it is the last one using a specific intrinsic, it now removes the intrinsic.