Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calendar_table_view.js #1530

Closed
wants to merge 1 commit into from
Closed

Conversation

tm8544
Copy link

@tm8544 tm8544 commented May 15, 2024

provider.id filtering needs toString() to work

provider.id filtering needs toString() to work
@alextselegidis
Copy link
Owner

Hello!

Thanks for this PR.

This would be one solution, but the best (for consistency) would be to make sure the filterProviderIds array has Number values.

I will review this in more detail.

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

@tm8544
Copy link
Author

tm8544 commented May 15, 2024

at line 555: const filterProviderIds = $filterProvider.val().map((str) => parseInt(str, 10));

alextselegidis added a commit that referenced this pull request May 21, 2024
@alextselegidis
Copy link
Owner

Thanks, fixed

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

tm8544 added a commit to tm8544/easyappointments that referenced this pull request May 21, 2024
@tm8544 tm8544 deleted the patch-5 branch May 23, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants